DOC: Improved links between expanding and cum* (GH12651) #14098
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified the auto-generating function so that the name of actual method [min/max/sum/prod] is available for link.
jorisvandenbossche
changed the title
Fixed the PEP8 incompatible line lengths.
Current coverage is 85.26% (diff: 100%)@@ master #14098 diff @@
==========================================
Files 139 139
Lines 50490 50502 +12
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43053 43063 +10
- Misses 7437 7439 +2
Partials 0 0
|
|
|
||
| sn = pd.Series([1,2,np.nan,3,np.nan,4]) | ||
|
|
||
| sn.expanding().sum() |
There was a problem hiding this comment.
I would specify min_periods explicty here, as that is what we are highliting. (and maybe change the example a bit so min_periods=1 and min_periods=2) show different results.
you may need to make this a sub-section rather than a note (as its getting long)
There was a problem hiding this comment.
Updated this in 30025d8
jreback
added
Reshaping
|
can you update |
|
can you rebase and update this? |
|
@adrian-stepien Thanks! (adapted it a little bit for @jreback's comments) |
ischurov
pushed a commit
to ischurov/pandas
that referenced
this pull request
Dec 19, 2016
- [x] closes pandas-dev#12651 - [x] passes `git diff upstream/master | flake8 --diff` Author: adrian-stepien <[email protected]> Closes pandas-dev#14098 from adrian-stepien/doc/12651 and squashes the following commits: 4427e28 [adrian-stepien] DOC: Improved links between expanding and cum* (pandas-dev#12651) 8466669 [adrian-stepien] DOC: Improved links between expanding and cum* (pandas-dev#12651) 30164f3 [adrian-stepien] DOC: Correct link from b/ffill to fillna
ischurov
pushed a commit
to ischurov/pandas
that referenced
this pull request
Dec 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff